tests: fix builder id matching #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
laurentsimon
approved these changes
Oct 18, 2022
|
Merging, @laurentsimon let me know if the intent was to verify builders against |
|
EDIT: It does work on the CLI; something it just broken with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
There seems to have been an error where when checking various forms of builder IDs, the loop would return rather than check all builder IDs for the test.
Unfortunately, this breaks some tests:
noversion: true. If we want to regression test this behavior at each version, I can change that later./refs/tags/VERSION, justVERSIONdoes not succeed theMatchbehvaior.